Skip to content

Conversation

Lucsanszky
Copy link
Contributor

Description

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

It is not required by the `STS (ShelleyPOOL)` instance
It should not constrain `ShelleyEraImp` for the same
reason it does not constrain `ShelleyEraTest`.

See #4992
It should not constrain `ConwayEraImp` for the same
reason it does not constrain `ConwayEraTest`.

See #4992
Use certificates with deposits since Shelley style certificates
without deposits are no longer supported from Dijkstra era onwards.
Only use certificates with deposits
* Generalise compatible tests by using certificates with deposits
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
* Generalise compatible tests by using certificates with deposits
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
* Generalise compatible tests by using certificates with deposits
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
* Generalise compatible tests by using certificates with deposits
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
* Generalise compatible tests by using certificates with deposits
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
* Generalise compatible tests by using certificates with deposits
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
* Generalise compatible tests by using certificates with deposits
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
* Generalise compatible tests by using certificates with deposits
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
* Generalise compatible tests by using certificates with deposits
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant