Move pool deposits into StakePoolState #5234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/deposits-in-stakepoolstate
branch
from
db9b6bf to
1be9add
Compare
aniketd
commented
Aug 14, 2025
aniketd
force-pushed
the
aniketd/deposits-in-stakepoolstate
branch
4 times, most recently
from
7469b0b to
d2712dc
Compare
aniketd
force-pushed
the
aniketd/deposits-in-stakepoolstate
branch
3 times, most recently
from
ec5540c to
f5a2b4d
Compare
aniketd
commented
Aug 21, 2025
lehins
reviewed
Aug 21, 2025
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/Types.hs
Outdated
Show resolved
Hide resolved
aniketd
force-pushed
the
aniketd/deposits-in-stakepoolstate
branch
from
f5a2b4d to
af11893
Compare
* Add `spsDeposit` field to `StakePoolState` * Remove `psDeposits` field from `PState` data constructor * Update `mkStakePoolState` to take deposit parameter as first argument * Replace `psDepositsL` and `psDepositsCompactL` lenses with `psDepositsG` and `psDepositsCompactG` getters * Remove `payPoolDeposit` and `refundPoolDeposit` functions * Update `EncCBOR`/`DecCBOR` instances for `PState` to handle new structure * Add lenses for `StakePoolState` fields
Also, * Use `mempty` deposits for genesis stake pools per specification. * Remove `epochStatePoolParamsL` lens. * Add prUTxOStateL, prChainAccountStateL, prCertStateL lenses to PoolReap exports.
- Replace newPool/reregPool by a singular regPool. - Remove addPoolDeposits. - Update test examples to use this new way of handling pool deposits. - Update ledger state golden test.
aniketd
force-pushed
the
aniketd/deposits-in-stakepoolstate
branch
from
af11893 to
41420d9
Compare
lehins
approved these changes
Aug 25, 2025
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Rules/AdaPreservation.hs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5190
Checklist
Tests added or updated when needed.CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
Versions updated in.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
Version bounds in.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).