Skip to content

Conversation

fmaste
Copy link
Contributor

@fmaste fmaste commented Aug 15, 2025

Description

Remove non-p2p profiles and makes P2P the implicit default for node 10.6.

  • Removed profiles:
    • value-nomadperf-nop2p
    • value-oldtracing-nomadperf-nop2p
    • plutus-nomadperf-nop2p
    • fast-nomadperf-nop2p
    • ci-test-nomadperf-nop2p
    • default-nomadperf-nop2p
    • oldtracing-nomadperf-nop2p
    • ci-bench-nomadperf-nop2p
  • Profiles with the "-p2p" suffix removed:
    • fast-p2p
    • ci-test-p2p
    • default-p2p
    • forge-stress-p2p
    • ci-bench-p2p
    • 10-p2p
    • chainsync-early-alonzo-p2p
  • Profiles that switched to "p2p":
    • fast-solo
    • fast (was fast-p2p)
    • fast-oldtracing
    • fast-notracer
    • fast-plutus
    • ci-test (was ci-test-p2p)
    • ci-test-rtview
    • ci-test-notracer
    • ci-test-plutus
    • trace-bench
    • trace-bench-rtview
    • trace-bench-oldtracing
    • trace-bench-plutus
    • trace-full
    • trace-full-rtview
    • default (was default-p2p)
    • oldtracing
    • plutus
    • plutus-secp-ecdsa
    • plutus-secp-schnorr
    • epoch-transition
    • k3-3ep-5kTx-10000kU-1300kD-64kbs-fixed-loaded
    • k3-3ep-9kTx-10000kU-1300kD-64kbs-5tps-fixed-loaded
    • k3-3ep-18kTx-10000kU-1300kD-64kbs-10tps-fixed-loaded
    • ci-test-dense10
    • dish
    • dish-10M
    • dish-plutus
    • dish-10M-plutus
    • ci-bench (was ci-bench-p2p)
    • ci-bench-rtview
    • ci-bench-notracer
    • ci-bench-drep
    • ci-bench-plutus
    • ci-bench-plutus24
    • ci-bench-plutus-secp-ecdsa
    • ci-bench-plutus-secp-schnorr
    • ci-bench-plutusv3-blst
    • ci-bench-plutusv3-ripemd
    • ci-bench-plutusv3-ripemd-step2x
    • 10 (was 10-p2p)
    • 10-notracer
    • 10-plutus
    • 6-dense
    • 6-dense-rtsprof
    • 6-dense-1h
    • 6-dense-1h-rtsprof
    • 6-dense-4h
    • 6-dense-4h-rtsprof
    • plutuscall-loop
    • plutuscall-loop-memx2
    • plutuscall-secp-ecdsa
    • plutuscall-secp-ecdsa-stepx
    • plutuscall-secp-schnorr
    • plutuscall-secp-schnorr-stepx2
    • plutuscall-volt-loop
    • plutuscall-volt-blst
    • chainsync-early-byron
    • chainsync-early-byron-notracer
    • chainsync-early-byron-oldtracing
    • chainsync-early-alonzo (was chainsync-early-alonzo-p2p)
    • chainsync-early-alonzo-notracer
    • chainsync-early-alonzo-oldtracing
    • devops
    • idle
    • tracer-only
    • development-voting

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@fmaste fmaste force-pushed the bench-rm-nonp2p-topology branch 6 times, most recently from 77d9b33 to da23250 Compare August 19, 2025 16:48
@fmaste fmaste force-pushed the bench-rm-nonp2p-topology branch from da23250 to 68825d3 Compare August 19, 2025 17:07
@fmaste fmaste marked this pull request as ready for review August 19, 2025 17:07
@fmaste fmaste requested review from a team as code owners August 19, 2025 17:07
@fmaste fmaste changed the title Bench rm nonp2p topology bench: rm nonp2p topology Aug 19, 2025
Copy link
Contributor

@jutaro jutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmaste fmaste added this pull request to the merge queue Aug 20, 2025
Merged via the queue into master with commit 28bdde6 Aug 20, 2025
23 checks passed
@fmaste fmaste deleted the bench-rm-nonp2p-topology branch August 20, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants