-
Notifications
You must be signed in to change notification settings - Fork 740
Port cardano-submit-api
to trace-dispatcher
#6326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Russoul
wants to merge
4
commits into
master
Choose a base branch
from
russoul/cardano-submit-api-trace-dispatcher
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trace-dispatcher
trace-dispatcher
cardano-submit-api
to trace-dispatcher
mgmeier
requested changes
Sep 30, 2025
5591f86
to
71a8f7d
Compare
71a8f7d
to
a10c34c
Compare
a10c34c
to
5b52a85
Compare
5b52a85
to
2ef6da2
Compare
jutaro
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me.
import Cardano.Logging.Types (BackendConfig (..), | ||
ConfigOption (ConfBackend, ConfSeverity), FormatLogging (HumanFormatColoured), | ||
SeverityF (SeverityF), SeverityS (Info)) | ||
import qualified Cardano.Logging.Types as TraceD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not replace with: import Cardano.Logging as TraceD?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iohk-monitoring
withtrace-dispatcher
gauge
tocounter
of bothtx_submit_fail
andtx_submit
metrics.counter
instead ofcount
The iohk-nix Node 10.6 PR (input-output-hk/iohk-nix#602) needs to be merged first, and
iohkNix
bumped onmaster
, before this one can be merged.