Skip to content

Conversation

Russoul
Copy link

@Russoul Russoul commented Sep 16, 2025

  • The PR replaces the older tracing & metric system — iohk-monitoring with trace-dispatcher
    • To better the model of existing metrics, the PR changes prometheus metric type from gauge to counter of both tx_submit_fail and tx_submit metrics.
    • In the interest of keeping naming in line with trace-dispatcher, the PR introduces a slightly different prometheus suffix for counters: counter instead of count

The iohk-nix Node 10.6 PR (input-output-hk/iohk-nix#602) needs to be merged first, and iohkNix bumped on master, before this one can be merged.

@Russoul Russoul changed the title Start porting cardano-submit-api to trace-dispatcher Port cardano-submit-api to trace-dispatcher Sep 23, 2025
@Russoul Russoul changed the title Port cardano-submit-api to trace-dispatcher Port cardano-submit-api to trace-dispatcher Sep 23, 2025
@Russoul Russoul changed the title Port cardano-submit-api to trace-dispatcher Port cardano-submit-api to trace-dispatcher Sep 23, 2025
@mgmeier mgmeier force-pushed the russoul/cardano-submit-api-trace-dispatcher branch from 5591f86 to 71a8f7d Compare September 30, 2025 08:50
@mgmeier mgmeier force-pushed the russoul/cardano-submit-api-trace-dispatcher branch from 71a8f7d to a10c34c Compare September 30, 2025 09:02
@Russoul Russoul force-pushed the russoul/cardano-submit-api-trace-dispatcher branch from a10c34c to 5b52a85 Compare September 30, 2025 10:32
@Russoul Russoul force-pushed the russoul/cardano-submit-api-trace-dispatcher branch from 5b52a85 to 2ef6da2 Compare September 30, 2025 10:36
@Russoul Russoul marked this pull request as ready for review September 30, 2025 14:48
@Russoul Russoul requested review from a team as code owners September 30, 2025 14:48
Copy link
Contributor

@jutaro jutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

import Cardano.Logging.Types (BackendConfig (..),
ConfigOption (ConfBackend, ConfSeverity), FormatLogging (HumanFormatColoured),
SeverityF (SeverityF), SeverityS (Info))
import qualified Cardano.Logging.Types as TraceD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not replace with: import Cardano.Logging as TraceD?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants