Add cardano-blueprint submodule and move handshake cddl to it #5056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch1bo
force-pushed
the
cardano-blueprint-handshake-example
branch
from
9e8b6ac to
a5f7956
Compare
This demonstrates how we could move the CDDL to a common repository and tested against from multiple implementations of the ouroboros protocols. Git submodules are obviously only one way of managing this dependency.
ch1bo
force-pushed
the
cardano-blueprint-handshake-example
branch
from
a5f7956 to
7f78055
Compare
|
@coot I'd love to use this PR as a basis for discussion on how we could move the CDDLs into a place where they are more easily consumed by other implementations. |
|
@ch1bo, such an approach will work, but first, this should be discussed in a wider forum, e.g. with consensus & ledger teams. We should not corner them with a decision like that. I haven't used git-submodules extensively, but enough to know it can be painful. Are there other possible approaches which avoid git-submodules? Can one use tags instead of git-hashes? It would be much nicer to say |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This demonstrates how we could move the CDDL to a common repository and test against it from multiple implementations of the ouroboros protocols.
Git submodules are obviously only one way of managing this dependency.
Checklist
Quality
Maintenance
ouroboros-networkproject.