network-spec: relax requirement after MsgIntersectFound
#5187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
approved these changes
Aug 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
network-spec: relax requirement after `MsgIntersectFound`
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4917 by relaxing the specification. Now, after an intersection for a point
ptwas negotiated, the server still must sendMsgRollBackward, but it can either send a rollback toptor to an earlier point.The motivation for sending
MsgRollBackwardafterMsgIntersectFound(simpler state management on the client side) is preserved by this change, and it simplifies the server implementation, ensuring that the current production ChainSync server implementation actually adheres to the spec.Checklist
Quality
Maintenance
ouroboros-networkproject.