Refactor: Use Submodule for efsw Instead of Manual Source Files #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration of
efsw
has been updated to use a git submodule rather than directly including individual source files. This makes future updates cleaner and more maintainable.It’s now linked as a static library via add_subdirectory, and a few minor tweaks were made externally to improve portability without modifying the original source. As a bonus, this also helps to reduce overall build time.
把 efsw 的引用方式改成了 git submodule 的方式,这样以后维护更简单的一些。
efsw 本身支持 cmake, 所以直接在顶层 CMakeLists.cmake 中用 add_subdirectory 来引用更加可维护,只要原作者的代码是可靠的,这里就是可靠的。
另外小改了一下顶层 CMakeLists.cmake 让其更加模块化