[MOB-10034] Example App: commerce #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstants, add associated icon, and update URL handling in IterableAppProvider
…urchase tracking, define Commerce route in navigation, and create associated constants and styles
…the correct Ruby version is loading
….9 and Android Gradle Plugin 8.7.2
…nfigurations for rbenv, nvm, Android SDK, Java, and Node
…0034-add-commerce-section
…0034-add-commerce-section
…0034-add-commerce-section
Base automatically changed from
2.0.0-alpha/MOB-10033-add-inbox
to
2.0.0-alpha/master
November 25, 2024 19:52
evantk91
approved these changes
Nov 26, 2024
Contributor
evantk91
left a comment
evantk91
left a comment
There was a problem hiding this comment.
Left a few comments but looks good overall.
| import { Route } from '../constants/routes'; | ||
|
|
||
| export type MainScreenParamList = { | ||
| [Route.Commerce]: undefined; |
Contributor
There was a problem hiding this comment.
Is this typed undefined until a type is figured out?
Contributor
Author
There was a problem hiding this comment.
It's typed as undefined because it's not expecting any props
|
|
||
| Iterable.trackPurchase(totalPrice, purchaseItems, dataFields); | ||
|
|
||
| console.group('Purchase tracked with the following arguments:'); |
Contributor
There was a problem hiding this comment.
Nice use of console.group
Contributor
Author
There was a problem hiding this comment.
Thanks! I use it a lot -- find it quite useful.
| ```bash | ||
| ruby --version | ||
| ``` | ||
| If working, it should say `3.3.6` |
Contributor
There was a problem hiding this comment.
Odd my computer has 2.6.10 running but the app is working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description
Added a commerce section to the example app
Testing
yarn installScreenshots
iOS
ios-commerce.mov
Android
android-commerce.mov