Skip to content

Conversation

@JunielKatarn
Copy link

Allows building natively for Windows/ARM64 devices (Surface Pro X, Volterra, etc).

@ArminiusTux
Copy link

Greetings, just wanted to drop my experience in compiling the MP portion on WinARM64.
The above "__rdtsc workaround" really gets the other two executables, openjk.x86_64.exe & openjkded.x86_64.exe compiled, but they crash outright.

The SP.exe is not exactly rock solid, but absolutely playable.

@ArminiusTux
Copy link

Is there any way to kick this can / pull request further down the road?

Comment on lines +89 to +90
${VcpkgDir}/installed/arm64-windows/lib/manual-link/SDL2main.lib
${VcpkgDir}/installed/arm64-windows/lib/SDL2.lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love having vendored versions for everything except arm64-windows.
I think my preference would be vendored versions for all, with optional sourcing from (system) package manager. I also don't love how much bloat and churn that entails. Maybe arm64-windows is a special-enough case to push for vcpkg.

This isn't a blocker, just provoking discussion so we can form a stance here intentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants