Skip to content

Conversation

@baptistegrimaud
Copy link
Contributor

@baptistegrimaud baptistegrimaud commented Oct 7, 2025

Description

Simplify provisioning files by replacing hard-coded versions by the Maven "metaversion" LATEST, that points to the latest version (including releases and snapshots).
The main benefit is that we won't need to update those files anymore when releasing (that bumps the version).

Run to validate the change: https://github.com/Jahia/javascript-modules/actions/runs/18312013907

Tip

Documentation to guide the reviews: How to do a code review

@baptistegrimaud baptistegrimaud marked this pull request as ready for review October 7, 2025 12:06
@baptistegrimaud baptistegrimaud requested a review from a team as a code owner October 7, 2025 12:06
Copilot AI review requested due to automatic review settings October 7, 2025 12:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies CI provisioning files by replacing hard-coded version numbers with Maven's "LATEST" metaversion, which automatically resolves to the most recent version including snapshots and releases. This eliminates the need to manually update version numbers in provisioning files during releases.

  • Replaced hard-coded version "0.9.0-SNAPSHOT" with "LATEST" metaversion in Maven coordinates
  • Updated two module dependencies: javascript-modules-engine-test-module and javascript-modules-samples-hydrogen

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@baptistegrimaud baptistegrimaud self-assigned this Oct 7, 2025
Copy link
Member

@GauBen GauBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's freaking go!

@baptistegrimaud baptistegrimaud enabled auto-merge (squash) October 7, 2025 12:22
@baptistegrimaud baptistegrimaud merged commit 1bd2ae5 into main Oct 7, 2025
16 checks passed
@baptistegrimaud baptistegrimaud deleted the simplify-js-urls-in-provisioning-files branch October 7, 2025 12:27
@ksagnard ksagnard self-requested a review October 7, 2025 12:53
@ksagnard
Copy link
Contributor

ksagnard commented Oct 7, 2025

TODO check latest manual run and latest nightly when the execution is completed

@x0h01 x0h01 self-requested a review October 10, 2025 08:25
@x0h01
Copy link
Contributor

x0h01 commented Oct 10, 2025

Nightly and manual runs passed.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants