Skip to content

Conversation

@GauBen
Copy link
Member

@GauBen GauBen commented Dec 2, 2025

Description

Small oopsie: we need dotenv in the vite plugin, not in the library

Checklist

Source code

  • I've shared and documented any breaking change
  • I've reviewed and updated the jahia-depends

Tests

  • I've provided Unit and/or Integration Tests
  • I've updated the parent issue with required manual validations

Tip

Documentation to guide the reviews: How to do a code review

@GauBen GauBen requested a review from a team as a code owner December 2, 2025 13:53
Copilot AI review requested due to automatic review settings December 2, 2025 13:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a dependency misplacement by moving the dotenv package from javascript-modules-library to vite-plugin where it is actually needed.

  • Adds dotenv dependency to vite-plugin/package.json
  • Removes dotenv dependency from javascript-modules-library/package.json

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
vite-plugin/package.json Adds dotenv ^17.2.3 to dependencies
javascript-modules-library/package.json Removes dotenv ^17.2.2 from dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GauBen GauBen enabled auto-merge (squash) December 3, 2025 07:57
@GauBen GauBen changed the title fix: move the dotenv dep to the right package chore: move the dotenv dep to the right package Dec 3, 2025
@GauBen GauBen merged commit e432860 into main Dec 17, 2025
15 checks passed
@GauBen GauBen deleted the fix/dotenv-oops branch December 17, 2025 10:14
@x0h01
Copy link
Contributor

x0h01 commented Dec 17, 2025

With:

  • Jahia 8.2.3.0 [Kimchi] - Build: 0e47150
  • dx:org.jahia.modules/javascript-modules-engine/1.1.0.SNAPSHOT (Git-last-commit-id: 0b268ab)
  • @jahia/create-module@1.1.0-alpha-20251217115503239

  • ✅️ no compilation errors during module build and publishing
  • ✅️ integration tests passed
  • ✅️ A minimal Hello World template set is created without errors
  • ✅️ hydrogen module is successfully imported to jahia
  • ✅️ no errors in browser console and jahia.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants