Skip to content

Replace new Buffer() with Buffer.alloc() as it is safer. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eraz1997 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace new Buffer() with Buffer.alloc() as it is safer. #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/array.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ module.exports = function Array (_type, _length) {
// use the "fixedLength" if provided, otherwise throw an Error
if (fixedLength > 0) {
this.length = fixedLength
this.buffer = new Buffer(this.length * item_size)
this.buffer = Buffer.alloc(this.length * item_size)
} else {
throw new Error('A "length", "array" or "buffer" must be passed as the first argument')
}
} else if ('number' == typeof data) {
// new IntArray(69)
this.length = data
this.buffer = new Buffer(this.length * item_size)
this.buffer = Buffer.alloc(this.length * item_size)
} else if (isArray(data)) {
// new IntArray([ 1, 2, 3, 4, 5 ], {len})
// use optional "length" if provided, otherwise use "fixedLength, otherwise
Expand All @@ -60,7 +60,7 @@ module.exports = function Array (_type, _length) {
throw new Error('array length must be at least ' + len + ', got ' + data.length)
}
this.length = len
this.buffer = new Buffer(len * item_size)
this.buffer = Buffer.alloc(len * item_size)
for (var i = 0; i < len; i++) {
this[i] = data[i]
}
Expand Down