Tests fixes #328
Merged
Tests fixes #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formatting to substitute sys.executable was not effective because the formatted string was discarded. But even when when the substitution is made, pandoc ignores the shebang line in the file when the file is not executable and invokes it using 'python'. This second issue was hiding the first. We need to fix both to actually execute code using the desired sys.executable. Finally, the first .format() was interfering with the second .format().
|
Can you please describe what is getting done here. Seems like the work of #327 |
I don't think those are related. The first patch in this PR fixes an obvious bug in tests. I think the commit description is very clear. The other two patches are minor cleanups. ?? |
|
Fantastic work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.