Kotlin 2.2.20 #2491
Kotlin 2.2.20 #2491
Conversation
buildSrc/private/src/main/kotlin/androidx/build/AndroidXComposeImplPlugin.kt
Outdated
Show resolved
Hide resolved
| languageVersion.set(KotlinVersion.KOTLIN_2_1) | ||
| apiVersion.set(KotlinVersion.KOTLIN_2_1) | ||
| languageVersion.set(KotlinVersion.KOTLIN_2_2) | ||
| apiVersion.set(KotlinVersion.KOTLIN_2_2) |
There was a problem hiding this comment.
Why do we need it? It's KOTLIN_2_0 in AOSP and in general it should be the same. It was bumped to 2.1 because of changes in datetime
There was a problem hiding this comment.
because of the errors in the existing code saying the features are only available in LV_2_2
There was a problem hiding this comment.
🤔 where it was required? why did it work?
There was a problem hiding this comment.
compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/SharedTransitionScope.kt:813:39 Default parameters in open @Composable functions are not supported before language version 2.2 (configured version is 2.1)
There was a problem hiding this comment.
It's common code and AOSP compiles it with 2_0. I don't understand why it works. Bumping it mono-repo wide seems like hiding another issue
There was a problem hiding this comment.
There was a problem hiding this comment.
I created a task to lower the LV back before 1.10.0-beta02 - https://youtrack.jetbrains.com/issue/CMP-9144 so we could proceed here.
There was a problem hiding this comment.
Since beta01 merge is already waiting, I don't see the reason to postpone this revert. But in general, I guess it's not a blocker
There was a problem hiding this comment.
Here, I can revert the function declration manually - which is not good I suppose.
But I can't revert the LV bump because the CI would become red.
There was a problem hiding this comment.
Yep, I mean let's revert it before beta01, not beta02
eymar
force-pushed
the
ok/jb-main-kotlin-2-2-20_new
branch
2 times, most recently
from
7879539 to
8f3a14b
Compare
eymar
force-pushed
the
ok/jb-main-kotlin-2-2-20_new
branch
from
8f3a14b to
7f3bccc
Compare
| kotlin = "2.2.20" | ||
| kotlinComposeCompiler = "2.2.20" | ||
| kotlinBenchmark = "0.4.11" | ||
| kotlinComposeCompiler = "2.2.10-441" |
There was a problem hiding this comment.
Nitpick, please keep things sorted
2 participants
Testing
N/A
Release Notes
N/A