Skip to content

update: (mostly) latest libraries and updated UI code #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2025

Conversation

zamulla
Copy link
Collaborator

@zamulla zamulla commented Jul 24, 2025

@ElviraMustafina
Copy link
Collaborator

ElviraMustafina commented Jul 28, 2025

Issues with the tutorial not related to the pull request:

Create a project, step 3: in Android Studio, you need to choose Generic on the left pane, and then Kotlin Multiplaform. Is it expected?

@ElviraMustafina
Copy link
Collaborator

Bullet lists after code samples look confusing, as you're expected to figure out extra steps on your own after adding the provided lines.

@ElviraMustafina
Copy link
Collaborator

ElviraMustafina commented Jul 28, 2025

The use of packages vs directories is inconsistent.

UPD: I replaced directories with packages for the cases where you're trying to add a new directory, but the menu only allows you to create a new package.

@ElviraMustafina
Copy link
Collaborator

Missing imports in SpaceXApi.kt:

import com.jetbrains.spacetutorial.entity.RocketLaunch
import io.ktor.client.call.body
import io.ktor.client.request.get

@ElviraMustafina
Copy link
Collaborator

For AndroidManifest.xml, if the provided lines are supposed to be placed in the middle of the activity and application sections, then they should be without >. Otherwise, remove the ... following the line.

@zamulla zamulla requested a review from ElviraMustafina July 28, 2025 12:28
@zamulla zamulla merged commit 28c3376 into master Jul 28, 2025
@zamulla zamulla deleted the sql-ktor-update branch July 28, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants