-
Notifications
You must be signed in to change notification settings - Fork 386
Mark stable classes for Compose #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Goooler
wants to merge
1
commit into
JetBrains:main
Choose a base branch
from
Goooler:stable-classes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@Goooler I tried running a build on this branch to see the stability report with / without this stability configuration, but none of my builds produced any reports. Do you have a way of generating them that works on your end? |
Contributor
Author
|
Yeah, I see it. The Compose stability reports are not always generated. Related task inputs and outputs may not work correctly. |
Contributor
Author
|
Finally, get the diff result from my 2 devices. diff --color=auto -r before/shared/shared_release-classes.txt after/shared/shared_release-classes.txt
47c47
< unstable val client: HttpClient
---
> stable val client: HttpClient
55c55
< unstable val scope: CoroutineScope
---
> stable val scope: CoroutineScope
82c82
< unstable val scope: CoroutineScope
---
> stable val scope: CoroutineScope
86,90c86,90
< unstable class TagValues {
< unstable val categories: List<String>
< unstable val levels: List<String>
< unstable val formats: List<String>
< <runtime stability> = Unstable
---
> stable class TagValues {
> stable val categories: List<String>
> stable val levels: List<String>
> stable val formats: List<String>
> <runtime stability> =
123,126c123,126
< unstable class Conference {
< unstable val sessions: List<Session>
< unstable val speakers: List<Speaker>
< <runtime stability> = Unstable
---
> stable class Conference {
> stable val sessions: List<Session>
> stable val speakers: List<Speaker>
> <runtime stability> =
132,134c132,134
< unstable class Votes {
< unstable val votes: List<VoteInfo>
< <runtime stability> = Unstable
---
> stable class Votes {
> stable val votes: List<VoteInfo>
> <runtime stability> =
152c152
< unstable class Session {
---
> stable class Session {
156c156
< unstable val speakerIds: List<SpeakerId>
---
> stable val speakerIds: List<SpeakerId>
158,160c158,160
< unstable val startsAt: LocalDateTime
< unstable val endsAt: LocalDateTime
< unstable val tags: List<String>?
---
> stable val startsAt: LocalDateTime
> stable val endsAt: LocalDateTime
> stable val tags: List<String>?
162c162
< <runtime stability> = Unstable
---
> <runtime stability> =
198c198
< unstable class NewsItem {
---
> stable class NewsItem {
202c202
< unstable val publicationDate: LocalDateTime
---
> stable val publicationDate: LocalDateTime
204c204
< <runtime stability> = Unstable
---
> <runtime stability> = Stable
210c210
< unstable class NewsRequest {
---
> stable class NewsRequest {
212c212
< unstable val publicationDate: LocalDateTime
---
> stable val publicationDate: LocalDateTime
215c215
< <runtime stability> = Unstable
---
> <runtime stability> = Stable
221,223c221,223
< unstable class NewsListResponse {
< unstable val items: List<NewsItem>
< <runtime stability> = Unstable
---
> stable class NewsListResponse {
> stable val items: List<NewsItem>
> <runtime stability> =
244c244
< unstable class SessionCardView {
---
> stable class SessionCardView {
249,250c249,250
< unstable val startsAt: LocalDateTime
< unstable val endsAt: LocalDateTime
---
> stable val startsAt: LocalDateTime
> stable val endsAt: LocalDateTime
252c252
< unstable val speakerIds: List<SpeakerId>
---
> stable val speakerIds: List<SpeakerId>
256c256
< unstable val tags: Set<String>
---
> stable val tags: Set<String>
262c262
< <runtime stability> = Unstable
---
> <runtime stability> =
293,296c293,296
< unstable class Day {
< unstable val date: LocalDate
< unstable val timeSlots: List<TimeSlot>
< <runtime stability> = Unstable
---
> stable class Day {
> stable val date: LocalDate
> stable val timeSlots: List<TimeSlot>
> <runtime stability> =
298,300c298,300
< unstable class TimeSlot {
< unstable val startsAt: LocalDateTime
< unstable val endsAt: LocalDateTime
---
> stable class TimeSlot {
> stable val startsAt: LocalDateTime
> stable val endsAt: LocalDateTime
302c302
< unstable val sessions: List<SessionCardView>
---
> stable val sessions: List<SessionCardView>
304c304
< <runtime stability> = Unstable
---
> <runtime stability> =
427,429c427,429
< unstable class AboutConferenceEvent {
< unstable val sessionCard: SessionCardView?
< unstable val speakers: List<Speaker>?
---
> stable class AboutConferenceEvent {
> stable val sessionCard: SessionCardView?
> stable val speakers: List<Speaker>?
435c435
< <runtime stability> = Unstable
---
> <runtime stability> =
485,487c485,487
< unstable class DayHeaderItem {
< unstable val value: Day
< <runtime stability> = Unstable
---
> stable class DayHeaderItem {
> stable val value: Day
> <runtime stability> =
489,491c489,491
< unstable class TimeSlotTitleItem {
< unstable val value: TimeSlot
< <runtime stability> = Unstable
---
> stable class TimeSlotTitleItem {
> stable val value: TimeSlot
> <runtime stability> =
498,499c498,499
< unstable val value: SessionCardView
< unstable val tagMatches: List<String>
---
> stable val value: SessionCardView
> stable val tagMatches: List<String>
504,506c504,506
< unstable class ServiceEventItem {
< unstable val value: SessionCardView
< <runtime stability> = Unstable
---
> stable class ServiceEventItem {
> stable val value: SessionCardView
> <runtime stability> =
508,510c508,510
< unstable class ServiceEventGroupItem {
< unstable val value: List<SessionCardView>
< <runtime stability> = Unstable
---
> stable class ServiceEventGroupItem {
> stable val value: List<SessionCardView>
> <runtime stability> =
512,514c512,514
< unstable class WorkshopItem {
< unstable val workshops: List<SessionCardView>
< <runtime stability> = Unstable
---
> stable class WorkshopItem {
> stable val workshops: List<SessionCardView>
> <runtime stability> =
528,530c528,530
< unstable class Content {
< unstable val days: List<Day>
< unstable val items: List<ScheduleListItem>
---
> stable class Content {
> stable val days: List<Day>
> runtime val items: List<ScheduleListItem>
534c534
< <runtime stability> = Unstable
---
> <runtime stability> =
617c617
< unstable class DebugLogger {
---
> stable class DebugLogger {
619,620c619,620
< unstable val logs: MutableList<String>
< <runtime stability> = Unstable
---
> stable val logs: MutableList<String>
> <runtime stability> =
diff --color=auto -r before/shared/shared_release-composables.txt after/shared/shared_release-composables.txt
87c87
< unstable speakers: List<Speaker>
---
> stable speakers: List<Speaker>
247c247
< unstable scheduleItems: List<ScheduleListItem>
---
> scheduleItems: List<ScheduleListItem>
256c256
< unstable filterItems: List<FilterItem>? = @static emptyList()
---
> filterItems: List<FilterItem>? = @static emptyList()
267c267
< unstable session: SessionCardView
---
> stable session: SessionCardView
277c277
< unstable tagHighlights: List<String>? = @static emptyList()
---
> stable tagHighlights: List<String>? = @static emptyList()
diff --color=auto -r before/ui-components/ui-components_release-composables.txt after/ui-components/ui-components_release-composables.txt
83c83
< unstable tags: List<FilterItem>
---
> stable tags: List<FilterItem>
89c89
< unstable items: List<FilterItem>
---
> stable items: List<FilterItem>
218c218
< unstable tags: Set<String>
---
> stable tags: Set<String>
256c256
< unstable events: List<ServiceEventData>
---
> stable events: List<ServiceEventData>
297c297
< unstable inlineContent: Map<String, InlineTextContent>? = @static mapOf()
---
> stable inlineContent: Map<String, InlineTextContent>? = @static mapOf()
307c307
< unstable items: List<String>
---
> stable items: List<String>
322,323c322,323
< unstable tags: Set<String>
< unstable tagHighlights: List<String>
---
> stable tags: Set<String>
> stable tagHighlights: List<String>
346,347c346,347
< unstable tags: Set<String>
< unstable selectedTags: List<String>
---
> stable tags: Set<String>
> stable selectedTags: List<String>
354c354
< unstable tags: Set<String>
---
> stable tags: Set<String> |
```diff
diff --color=auto -r before/shared/shared_release-classes.txt after/shared/shared_release-classes.txt
47c47
< unstable val client: HttpClient
---
> stable val client: HttpClient
55c55
< unstable val scope: CoroutineScope
---
> stable val scope: CoroutineScope
82c82
< unstable val scope: CoroutineScope
---
> stable val scope: CoroutineScope
86,90c86,90
< unstable class TagValues {
< unstable val categories: List<String>
< unstable val levels: List<String>
< unstable val formats: List<String>
< <runtime stability> = Unstable
---
> stable class TagValues {
> stable val categories: List<String>
> stable val levels: List<String>
> stable val formats: List<String>
> <runtime stability> =
123,126c123,126
< unstable class Conference {
< unstable val sessions: List<Session>
< unstable val speakers: List<Speaker>
< <runtime stability> = Unstable
---
> stable class Conference {
> stable val sessions: List<Session>
> stable val speakers: List<Speaker>
> <runtime stability> =
132,134c132,134
< unstable class Votes {
< unstable val votes: List<VoteInfo>
< <runtime stability> = Unstable
---
> stable class Votes {
> stable val votes: List<VoteInfo>
> <runtime stability> =
152c152
< unstable class Session {
---
> stable class Session {
156c156
< unstable val speakerIds: List<SpeakerId>
---
> stable val speakerIds: List<SpeakerId>
158,160c158,160
< unstable val startsAt: LocalDateTime
< unstable val endsAt: LocalDateTime
< unstable val tags: List<String>?
---
> stable val startsAt: LocalDateTime
> stable val endsAt: LocalDateTime
> stable val tags: List<String>?
162c162
< <runtime stability> = Unstable
---
> <runtime stability> =
198c198
< unstable class NewsItem {
---
> stable class NewsItem {
202c202
< unstable val publicationDate: LocalDateTime
---
> stable val publicationDate: LocalDateTime
204c204
< <runtime stability> = Unstable
---
> <runtime stability> = Stable
210c210
< unstable class NewsRequest {
---
> stable class NewsRequest {
212c212
< unstable val publicationDate: LocalDateTime
---
> stable val publicationDate: LocalDateTime
215c215
< <runtime stability> = Unstable
---
> <runtime stability> = Stable
221,223c221,223
< unstable class NewsListResponse {
< unstable val items: List<NewsItem>
< <runtime stability> = Unstable
---
> stable class NewsListResponse {
> stable val items: List<NewsItem>
> <runtime stability> =
244c244
< unstable class SessionCardView {
---
> stable class SessionCardView {
249,250c249,250
< unstable val startsAt: LocalDateTime
< unstable val endsAt: LocalDateTime
---
> stable val startsAt: LocalDateTime
> stable val endsAt: LocalDateTime
252c252
< unstable val speakerIds: List<SpeakerId>
---
> stable val speakerIds: List<SpeakerId>
256c256
< unstable val tags: Set<String>
---
> stable val tags: Set<String>
262c262
< <runtime stability> = Unstable
---
> <runtime stability> =
293,296c293,296
< unstable class Day {
< unstable val date: LocalDate
< unstable val timeSlots: List<TimeSlot>
< <runtime stability> = Unstable
---
> stable class Day {
> stable val date: LocalDate
> stable val timeSlots: List<TimeSlot>
> <runtime stability> =
298,300c298,300
< unstable class TimeSlot {
< unstable val startsAt: LocalDateTime
< unstable val endsAt: LocalDateTime
---
> stable class TimeSlot {
> stable val startsAt: LocalDateTime
> stable val endsAt: LocalDateTime
302c302
< unstable val sessions: List<SessionCardView>
---
> stable val sessions: List<SessionCardView>
304c304
< <runtime stability> = Unstable
---
> <runtime stability> =
427,429c427,429
< unstable class AboutConferenceEvent {
< unstable val sessionCard: SessionCardView?
< unstable val speakers: List<Speaker>?
---
> stable class AboutConferenceEvent {
> stable val sessionCard: SessionCardView?
> stable val speakers: List<Speaker>?
435c435
< <runtime stability> = Unstable
---
> <runtime stability> =
485,487c485,487
< unstable class DayHeaderItem {
< unstable val value: Day
< <runtime stability> = Unstable
---
> stable class DayHeaderItem {
> stable val value: Day
> <runtime stability> =
489,491c489,491
< unstable class TimeSlotTitleItem {
< unstable val value: TimeSlot
< <runtime stability> = Unstable
---
> stable class TimeSlotTitleItem {
> stable val value: TimeSlot
> <runtime stability> =
498,499c498,499
< unstable val value: SessionCardView
< unstable val tagMatches: List<String>
---
> stable val value: SessionCardView
> stable val tagMatches: List<String>
504,506c504,506
< unstable class ServiceEventItem {
< unstable val value: SessionCardView
< <runtime stability> = Unstable
---
> stable class ServiceEventItem {
> stable val value: SessionCardView
> <runtime stability> =
508,510c508,510
< unstable class ServiceEventGroupItem {
< unstable val value: List<SessionCardView>
< <runtime stability> = Unstable
---
> stable class ServiceEventGroupItem {
> stable val value: List<SessionCardView>
> <runtime stability> =
512,514c512,514
< unstable class WorkshopItem {
< unstable val workshops: List<SessionCardView>
< <runtime stability> = Unstable
---
> stable class WorkshopItem {
> stable val workshops: List<SessionCardView>
> <runtime stability> =
528,530c528,530
< unstable class Content {
< unstable val days: List<Day>
< unstable val items: List<ScheduleListItem>
---
> stable class Content {
> stable val days: List<Day>
> runtime val items: List<ScheduleListItem>
534c534
< <runtime stability> = Unstable
---
> <runtime stability> =
617c617
< unstable class DebugLogger {
---
> stable class DebugLogger {
619,620c619,620
< unstable val logs: MutableList<String>
< <runtime stability> = Unstable
---
> stable val logs: MutableList<String>
> <runtime stability> =
diff --color=auto -r before/shared/shared_release-composables.txt after/shared/shared_release-composables.txt
87c87
< unstable speakers: List<Speaker>
---
> stable speakers: List<Speaker>
247c247
< unstable scheduleItems: List<ScheduleListItem>
---
> scheduleItems: List<ScheduleListItem>
256c256
< unstable filterItems: List<FilterItem>? = @static emptyList()
---
> filterItems: List<FilterItem>? = @static emptyList()
267c267
< unstable session: SessionCardView
---
> stable session: SessionCardView
277c277
< unstable tagHighlights: List<String>? = @static emptyList()
---
> stable tagHighlights: List<String>? = @static emptyList()
diff --color=auto -r before/ui-components/ui-components_release-composables.txt after/ui-components/ui-components_release-composables.txt
83c83
< unstable tags: List<FilterItem>
---
> stable tags: List<FilterItem>
89c89
< unstable items: List<FilterItem>
---
> stable items: List<FilterItem>
218c218
< unstable tags: Set<String>
---
> stable tags: Set<String>
256c256
< unstable events: List<ServiceEventData>
---
> stable events: List<ServiceEventData>
297c297
< unstable inlineContent: Map<String, InlineTextContent>? = @static mapOf()
---
> stable inlineContent: Map<String, InlineTextContent>? = @static mapOf()
307c307
< unstable items: List<String>
---
> stable items: List<String>
322,323c322,323
< unstable tags: Set<String>
< unstable tagHighlights: List<String>
---
> stable tags: Set<String>
> stable tagHighlights: List<String>
346,347c346,347
< unstable tags: Set<String>
< unstable selectedTags: List<String>
---
> stable tags: Set<String>
> stable selectedTags: List<String>
354c354
< unstable tags: Set<String>
---
> stable tags: Set<String>
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.