Wrap Icon in TopMenuButtonImpl in a TooltipBox to be able to show a tooltip for Toolbar menu items #477
Conversation
|
As I wrote, unfortunately the background color of the tooltip is not correct in light theme, it still uses a dark color. OFC it could be solved with specifying the Probably something in themes should be modified. Can you help with this @zsmb13? Thanks! |
balazsgerlei
force-pushed
the
add-toolbar-tooltips
branch
2 times, most recently
from
b6c8ce9 to
051ec1f
Compare
balazsgerlei
force-pushed
the
add-toolbar-tooltips
branch
from
051ec1f to
a000c0a
Compare
|
I set the color explcitly for ToolTipbox's background (it is done like that in the app if I saw right), based on the colors used by Google's Messages app and after a brief discussion with @zsmb13 I added new colors for not just the background but the text color as well and left primaryTextInverted as it was (not inverted in dark theme). I think the PR is now ready for review! |
…ooltip for Toolbar menu items - On Android, long pressing on a Toolbar menu item should display the menu items' names in a tooltip - The Tooltip's background color is not correct yet in light mode (it uses a dark color for some reason) - Content description is used as the tooltip text
- Set containerColor (background) to a dark color and text color to a light in light mode and the inverse on dark (it is done this way in another apps) - Make primaryTextInverted really inverted in dark mode too - Add two new colors: blueGrey and offWhite, based on what other apps use as tooltip background colors - Add new tooltipBackground color to app theme Colors, use primaryTextInverted for Tooltip text color
- Revert changing primaryTextInverted for dark theme (apparently, it was intentionally the same color as primaryText)
balazsgerlei
force-pushed
the
add-toolbar-tooltips
branch
from
de8754f to
c185f9b
Compare
# Conflicts: # ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/TopMenuButton.kt
|
Since we removed Material 3 in #553, I've added a commit that drops down to using the Foundation APIs for tooltips instead. These seem reasonably good too. For colors and design, I've temporarily set it to some existing color tokens from our design system - but I'll ask for input from the app's designer on what these should look like and get back to this. |
2 participants
Fixes #476