fix: isPropertyReadonlyInType crash on readonly array of a generic arrow function parameter #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…row function parameter
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
+ Coverage 61.00% 61.13% +0.12%
==========================================
Files 35 35
Lines 2921 2923 +2
Branches 463 467 +4
==========================================
+ Hits 1782 1787 +5
+ Misses 1139 1136 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return ( | ||
| !!propertySymbol.links && | ||
| isTransientSymbolLinksFlagSet( | ||
| (propertySymbol as ts.TransientSymbol).links, |
There was a problem hiding this comment.
Why do we need the as cast here but not 2 lines above?
| ).toBe(false); | ||
| }); | ||
|
|
||
| it("does not crash when the property is inside a readonly array of a generic arrow function parameter", () => { |
There was a problem hiding this comment.
does not crash
That's a pretty low expectation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
isPropertyReadonlyInTypeon argument to readonly type parameter (?) #754status: accepting prsOverview
The
propertySymbolbeing checked inisInConstContextmight not be ats.TransientSymbolwith.links.The test case is from typescript-eslint/typescript-eslint#11289 and fails on
main.💖