Refactored UX (#2) #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealshabi
reviewed
Oct 3, 2017
| android:layout_height="0dp" | ||
| android:layout_weight="1" | ||
| android:hint="name" | ||
| android:layout_marginRight="20dp" |
There was a problem hiding this comment.
MarginRight and MarginLeft is deprecated now, use marginStart and marginEnd instead
There was a problem hiding this comment.
@therealshabi Did the required changes.
therealshabi
reviewed
Oct 3, 2017
| android:layout_marginRight="20dp" | ||
| app:met_textColorHint="#bdbdbd" | ||
| android:layout_weight="1" | ||
| android:hint="enrollment number(only for JIIT students)" |
There was a problem hiding this comment.
Add all the hardcoded Strings in the strings.xml file and use from there
therealshabi
reviewed
Oct 3, 2017
|
|
||
|
|
||
| <RadioButton | ||
| android:id="@+id/hosteller" |
There was a problem hiding this comment.
id should be like rb_hosteller, hosteller does not imply that this is a radioButton
therealshabi
approved these changes
Oct 3, 2017
|
@therealshabi Done all the changes, as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
I've also Reformatted Code of activity_register.xml to make it more readable.