feat: add specialized fast implementations of Polynomial + constant and Polynomial + Variable
#179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/fast-ops
branch
2 times, most recently
from
b4d5973 to
0ca8e5f
Compare
AayushSabharwal
force-pushed
the
as/fast-ops
branch
from
0ca8e5f to
d914c32
Compare
AayushSabharwal
force-pushed
the
as/fast-ops
branch
from
d914c32 to
fd8154f
Compare
blegat
reviewed
Aug 16, 2025
src/operators.jl
Outdated
| """ | ||
| _constant_term_idx(p::Polynomial) | ||
| Return the index of the constant term in `p` according to its monomial ordering. |
There was a problem hiding this comment.
It's not the constant term, it is the lowest term since there could also be no constant term.
There was a problem hiding this comment.
I renamed the function
blegat
reviewed
Aug 16, 2025
Co-authored-by: Benoît Legat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.