Skip to content

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jul 18, 2025

checkindex for an AbstractFill index was being pirated by IniniteArrays.lj, and incompletely, since the Bool array behaves differently from an Int one. This PR moves the method to this package, where it belongs.

Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (877375f) to head (d8e3f3c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #411   +/-   ##
=======================================
  Coverage   99.48%   99.48%           
=======================================
  Files           8        8           
  Lines        1157     1159    +2     
=======================================
+ Hits         1151     1153    +2     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub
Copy link
Member Author

jishnub commented Jul 18, 2025

The test failures in InfiniteArrays.jl and InfiniteLinearAlgebra.jl are expected because of this type-piracy. Setting persistent_tasks=false in the Aqua checks gets the tests to pass.

@jishnub jishnub requested a review from dlfivefifty August 24, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant