-
Notifications
You must be signed in to change notification settings - Fork 1
Move to extensions #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 3 +2
Lines 7 14 +7
=========================================
+ Hits 7 14 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Looks good, thanks for the work! I don't know of anywhere else in the ecosystem that this would really fit into so I thinking having a stand-alone package is fine. My only note is that I'm not familiar with TestItemRunners and it looks like it's currently broken on nightly (see julia-vscode/TestItemRunner.jl#113). It seems like it could be overkill for this package, which doesn't have very many or very complicated tests, but if you think it's worth adding then I'm happy for you to do so. |
I don't have any experience with package extensions, so as far as I can say, it looks good to me! |
For sure, thanks for the feedback y'all! Right? I thought I was going crazy that we didn't already have this implemented somewhere. Maybe that's because right now it's basic enough for folks to just roll their own equation each time Totally agree Chris, TestItems is def overkill for this package rn, but I was thinking it might come in handy down the line as this package gets more things filled out from Mile's todo list. I've got an old draft PR going with Photometry.jl that uses TestItems, and it's been pretty pleasant being able to just pick what tests I want to run at the command line |
sounds good, lgtm |
Cool, will merge once the upstream issue you mentioned is fixed. Thanks all! |
Towards JuliaAstro/JuliaAstro.github.io#59 (comment)