Skip to content

Conversation

icweaver
Copy link
Member

@icweaver icweaver commented Sep 4, 2025

Towards JuliaAstro/JuliaAstro.github.io#59 (comment)

  • Move Unitful.jl to an extension
  • Add extension support for DynamicQuantities.jl

Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ed241b9) to head (22e72a3).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         3    +2     
  Lines            7        14    +7     
=========================================
+ Hits             7        14    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@icweaver icweaver mentioned this pull request Sep 4, 2025
3 tasks
@icweaver
Copy link
Member Author

icweaver commented Sep 8, 2025

Hi folks, started dusting things off a bit here. Any opposition to merging this patch in? Is there a better place that this functionality should live in the wider ecosystem?

cc: @abhro @cgarling

@cgarling
Copy link
Member

cgarling commented Sep 9, 2025

Looks good, thanks for the work! I don't know of anywhere else in the ecosystem that this would really fit into so I thinking having a stand-alone package is fine.

My only note is that I'm not familiar with TestItemRunners and it looks like it's currently broken on nightly (see julia-vscode/TestItemRunner.jl#113). It seems like it could be overkill for this package, which doesn't have very many or very complicated tests, but if you think it's worth adding then I'm happy for you to do so.

@abhro
Copy link
Member

abhro commented Sep 9, 2025

I don't have any experience with package extensions, so as far as I can say, it looks good to me!

@icweaver
Copy link
Member Author

icweaver commented Sep 9, 2025

For sure, thanks for the feedback y'all!

Right? I thought I was going crazy that we didn't already have this implemented somewhere. Maybe that's because right now it's basic enough for folks to just roll their own equation each time

Totally agree Chris, TestItems is def overkill for this package rn, but I was thinking it might come in handy down the line as this package gets more things filled out from Mile's todo list. I've got an old draft PR going with Photometry.jl that uses TestItems, and it's been pretty pleasant being able to just pick what tests I want to run at the command line

@cgarling
Copy link
Member

cgarling commented Sep 9, 2025

sounds good, lgtm

@icweaver
Copy link
Member Author

icweaver commented Sep 9, 2025

Cool, will merge once the upstream issue you mentioned is fixed. Thanks all!

@icweaver icweaver marked this pull request as ready for review September 9, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants