Add Tridiagonal construction rule #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
avik-pal
approved these changes
Nov 22, 2023
oxinabox
reviewed
Nov 23, 2023
Co-authored-by: Frames White <[email protected]>
ChrisRackauckas
commented
Nov 23, 2023
|
If tests pass (I know one of our CIs is broken for unzip) merge and tag (minor)!when happy. |
oxinabox
approved these changes
Nov 23, 2023
oxinabox
approved these changes
Nov 23, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Frames White <[email protected]>
|
Is there a minimal example of what problem this solves? There is some chance that it would be fixed by JuliaDiff/ChainRulesCore.jl#446 , which is really part of the original idea of ProjectTo. |
|
Not fixed just hit it here https://github.com/SciML/DiffEqFlux.jl/actions/runs/9115130596/job/25060691159?pr=922 |
|
Once JuliaDiff/FiniteDifferences.jl#237 |
|
What is the current status for this? |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SciML/DiffEqFlux.jl#744