Added furlongs test #758
Open
Added furlongs test #758
+123
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stemann
commented
Jul 28, 2025
| @@ -113,4 +114,10 @@ end | |||
| @test ForwardDiff.derivative(x -> (1+im)*x, 0) == (1+im) | |||
| end | |||
|
|
|||
| @testset "non-standard numbers" begin | |||
There was a problem hiding this comment.
Likely a non-descriptive test set name - feel free to suggest a better name.
stemann
force-pushed
the
feature/furlongs_test
branch
from
263b478 to
5a38c38
Compare
stemann
force-pushed
the
feature/furlongs_test
branch
from
5a38c38 to
d75ad63
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #758 +/- ##
=======================================
Coverage 89.33% 89.33%
=======================================
Files 11 11
Lines 1013 1013
=======================================
Hits 905 905
Misses 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Seems fine, but is this expected to pass without #665 ? (I would add a big comment linking to Base to explain which code is copied, and which is new tests.) |
|
Not sure, just trying to get the ball rolling :-) @longemen3000 suggested to add this test as a separate PR. Thoughts, @devmotion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added furlongs test - with
Furlongs.jlcopied from test/testhelpers in julia - implementing suggestion described in #665 (comment)