Support Julia 1.12 #529
Merged
Support Julia 1.12 #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/broadcast.jl b/src/broadcast.jl
index 58a30dd..f9d38f6 100644
--- a/src/broadcast.jl
+++ b/src/broadcast.jl
@@ -11,9 +11,9 @@ BroadcastStyle(W::Type{<:oneWrappedArray{T, N}}) where {T, N} =
# when we are dealing with different buffer styles, we cannot know
# which one is better, so use shared memory
BroadcastStyle(
- ::oneArrayStyle{N, B1},
- ::oneArrayStyle{N, B2},
- ) where {N,B1,B2} =
+ ::oneArrayStyle{N, B1},
+ ::oneArrayStyle{N, B2},
+) where {N, B1, B2} =
oneArrayStyle{N, oneL0.SharedBuffer}()
# allocation of output arrays
diff --git a/test/execution.jl b/test/execution.jl
index 596d0d8..1a7b654 100644
--- a/test/execution.jl
+++ b/test/execution.jl
@@ -307,12 +307,12 @@ end
@oneapi kernel(arr)
@test Array(arr)[] == 1
- function kernel2(ptr)
+ function kernel2(ptr)
ptr[] = 2
return
end
- @oneapi kernel2(arr)
+ @oneapi kernel2(arr)
@test Array(arr)[] == 2
end
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 79.17% 79.04% -0.14%
==========================================
Files 47 47
Lines 2997 3001 +4
==========================================
- Hits 2373 2372 -1
- Misses 624 629 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MagicMuscleMan
suggested changes
Sep 19, 2025
|
@maleadt Anything I can do here about? JuliaGPU/GPUCompiler.jl#101 |
|
Normally we add a quirk to avoid widening to 128-bits integers. |
|
Fixed by avoiding |
michel2323
force-pushed
the
julia1.12
branch
2 times, most recently
from
8ec8249 to
c2ad19b
Compare
|
@michel2323 JuliaGPU/OpenCL.jl#380 (and JuliaGPU/Metal.jl#576 and JuliaGPU/CUDA.jl#2917) has the fix for the current 1.12 error. |
|
Oh thanks so much! |
|
With Julia 1.12 officially released, is there a reason not to merge this PR in its current state? It might not be perfect, but it probably is still better than "even the most simple case is not working at all". Follow-up PRs should still be possible. |
|
It regresses 1.10/1.11, which is not acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.