Skip to content

Conversation

@topolarity
Copy link
Contributor

before:

ERROR: MagicMismatch("Magic Number 0x648610 does not match expected PE magic number 0x")

after:

ERROR: MagicMismatch("Magic Number 0x64860100 does not match expected PE magic number 0x50450000")

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.27%. Comparing base (427b624) to head (9ab9cbf).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/MachO/MachOHeader.jl 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   68.09%   70.27%   +2.18%     
==========================================
  Files          46       46              
  Lines        1332     1386      +54     
==========================================
+ Hits          907      974      +67     
+ Misses        425      412      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines -52 to -53
Magic Number 0x$(join(string.(magic, base=16),"")) does not match expected PE
magic number 0x$(join("", string.(PE_magic, base=16)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How....did this ever work 😕 I guess it never did. Also in v0.6, when this line

magic number 0x$(join("", hex.(PE_magic)))
was written, it gave the wrong result:

julia> join("", hex.(UInt8['P','E','\0','\0']))
""

@giordano giordano merged commit b309bd4 into JuliaIO:master Aug 12, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants