-
Notifications
You must be signed in to change notification settings - Fork 3
CompatHelper: bump compat for GPUCompiler to 1, (keep existing compat) #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for GPUCompiler to 1, (keep existing compat) #73
Conversation
170007d to
f4b6abb
Compare
01510b6 to
e9e9f57
Compare
This comment was marked as resolved.
This comment was marked as resolved.
e9e9f57 to
f05de79
Compare
This comment was marked as resolved.
This comment was marked as resolved.
f05de79 to
a213cce
Compare
|
https://github.com/JuliaIPU/IPUToolkit.jl/actions/runs/17356158450/job/49269413471?pr=73#step:10:157 @vchuravy I think I'd need your help to fix this one 🥲 The assert is coming from EnzymeAD/Enzyme.jl#2424 |
a213cce to
fc20735
Compare
e49c070 to
98d5c0c
Compare
|
For the record, we debugged the issue above with Valentin today and it seems to the be fixed by EnzymeAD/Enzyme.jl#2552, which simply replaces the assertion with a debug message (we only need to fix the content of the message though). Allowing for NativeCompilerTarget without primal compiler params doesn't appear to cause problems in this instance. |
This pull request changes the compat entry for the
GPUCompilerpackage from0.23, 0.24, 0.25, 0.26, 0.27to0.23, 0.24, 0.25, 0.26, 0.27, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.