Allow certain dependencies to be excluded for sysimg #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for a package to depend on more than it needs at runtime, for eaxmple, to allow switching backends. In some cases, it is desirable to exclude certain dependencies to avoid downloading or shipping with shipping artifacts that are not needed for an app.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
==========================================
- Coverage 95.25% 95.06% -0.20%
==========================================
Files 2 2
Lines 464 466 +2
==========================================
+ Hits 442 443 +1
- Misses 22 23 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DilumAluthge
changed the title
|
This feature looks great! I was just thinking of adding something like this myself. I would love to see this merged in soon specifically for excluding Revise.jl during package compilation. Any news on that front from the maintainers? One nit: the docstring refers to the kwarg as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for a package to depend on more than it needs, for eaxmple, to allow switching backends at run time. One example is the FFTW.jl.
In some cases, it is desirable to exclude certain dependencies to avoid downloading or shipping with shipping artifacts that are not needed for an app (e.g. the MKL_jll.jl which FFTW.jl depends on, but not used by default).
Potentially fix #639, where the unused package with lazy artifact can be explicitly excluded for building system image/app.