Adapt to current_terminfo becoming a OncePerProcess #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julia base is changing current_terminfo from a simple global variable to a OncePerProcess type. This commit updates all usage sites to call current_terminfo() as a function instead of accessing it directly. This is the counterpart to <JuliaLang/julia#58854>. For tests, we need to directly manipulate the OncePerProcess' internal value field, which relies on undocumented internals but is necessary for testing different terminal configurations without restarting the process.
|
This looks good to me, I've just tweaked the comment in I've also edited the commit message to reference #58854 directly. For the record, Claude seems to have done a solid job getting all the references and writing appropriate explanations for the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts to #58854. Generated with Claude Code.