Skip to content

IRShow: Print arg0 type when necessary to disambiguate invoke #58893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions Compiler/src/ssair/show.jl
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,30 @@ function print_stmt(io::IO, idx::Int, @nospecialize(stmt), code::Union{IRCode,Co
printstyled(io, "dynamic invoke "; color = :yellow)
abi = (ci::Core.MethodInstance).specTypes
end
show_unquoted(io, stmt.args[2], indent)
print(io, "(")
# XXX: this is wrong if `sig` is not a concretetype method
# more correct would be to use `fieldtype(sig, i)`, but that would obscure / discard Varargs information in show
sig = abi == Tuple ? Core.svec() : Base.unwrap_unionall(abi).parameters::Core.SimpleVector
f = stmt.args[2]
ft = maybe_argextype(f, code, sptypes)

# We can elide the type for arg0 if it...
skip_ftype = (length(sig) == 0) # doesn't exist...
skip_ftype = skip_ftype || (
# ... or, f prints as a user-accessible value...
(f isa GlobalRef) &&
# ... and matches the value of the singleton type of the invoked MethodInstance
(singleton_type(ft) === singleton_type(sig[1]) !== nothing)
)
if skip_ftype
show_unquoted(io, f, indent)
else
print(io, "(")
show_unquoted(io, f, indent)
print(io, "::", sig[1], ")")
end

# Print the remaining arguments (with type annotations from the invoked MethodInstance)
print(io, "(")
print_arg(i) = sprint(; context=io) do io
show_unquoted(io, stmt.args[i], indent)
if (i - 1) <= length(sig)
Expand Down