apply effects and gc_safe to GMP functionality
#59554
Draft
+261
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `ccall` macro, instead of raw `ccall`, to allow using
`gc_safe=true`.
* Apply some effects:
* `ccall`s get:
* `nothrow`, C code does not throw
* `terminates_globally`, GMP calls return
* `notaskstate`, GMP cannot know about Julia's tasks AFAIK
* non-mutating functions additionally get:
* `effect_free`
* In the `BigInt()` constructor, call the new form of `finalizer`:
`finalizer(func, b)` instead of `finalizer(ptr, b)`. The new form
is a builtin, so it is handled better by the compiler. See PR
JuliaLang#45423 and PR JuliaLang#59553.
|
The second commit here is not intended to be merged with the PR. I assume PR #59553, or a better one, will get merged before this PR. |
|
gc_safe might not add much here, in fact it probably adds more overhead than it helps. It's quite useful for long running ccalls of which I don't think any of these are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ccallmacro, instead of rawccall, to allow usinggc_safe=true.Apply some effects:
ccalls get:nothrow, C code does not throwterminates_globally, GMP calls returnnotaskstate, GMP cannot know about Julia's tasks AFAIKnon-mutating functions additionally get:
effect_freeIn the
BigInt()constructor, call the new form offinalizer:finalizer(func, b)instead offinalizer(ptr, b). The new form is a builtin, so it is handled better by the compiler. See PR Make finalizer a built-in #45423 and PR assume effectsterminates,noubforfinalizer#59553.