Fix aarch64 macOS crash when SIP disabled (re-land JLJITLinkMemoryManager/#60105) #60230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng#60105) Ports our RTDyLD memory manager to JITLink in order to avoid memory use regressions after switching to JITLink everywhere (JuliaLang#60031). This is a direct port: finalization must happen all at once, because it invalidates all allocation `wr_ptr`s. I decided it wasn't worth it to associate `OnFinalizedFunction` callbacks with each block, since they are large enough to make it extremely likely that all in-flight allocations land in the same block; everything must be relocated before finalization can happen.
Apple ARM CPUs treat the `ic ivau` as a memory read, which causes a confusing crash in DualMapAllocator if we try using it on a wr_addr that has been mprotected to `Prot::NO`, since we are still holding the allocator lock. For Apple aarch64 systems with SIP disabled, this will result in some memory savings, since DualMapAllocator will now work there. Like before, other JITLink platforms, namely Linux aarch64 and RISC-V, will benefit too. This re-lands JuliaLang#60105, after it was reverted in JuliaLang#60196. Thanks @giordano!
giordano
added
the
re-land
Member
$ csrutil status
System Integrity Protection status: disabled.
$ curl -Lfs -O https://buildkite.com/organizations/julialang/pipelines/julia-master/builds/52295/jobs/019ab7f4-9f21-4206-8395-2f9b0719abf0/artifacts/019ab800-02a3-45c3-bb4e-cee08e3a7917
$ tar xzf 019ab800-02a3-45c3-bb4e-cee08e3a7917
$ julia-068186c191/bin/julia
_
_ _ _(_)_ | Documentation: https://docs.julialang.org
(_) | (_) (_) |
_ _ _| |_ __ _ | Type "?" for help, "]?" for Pkg help.
| | | | | | |/ _` | |
| | |_| | | | (_| | | Version 1.14.0-DEV.1292 (2025-11-24)
_/ |\__'_|_|_|\__'_| | xal-0:jitlink-cgmemmgr/068186c191f (fork: 2 commits, 0 days)
|__/ |
julia>🥳 Edit: local build is also successful and can be started without issues: $ ./julia
_
_ _ _(_)_ | Documentation: https://docs.julialang.org
(_) | (_) (_) |
_ _ _| |_ __ _ | Type "?" for help, "]?" for Pkg help.
| | | | | | |/ _` | |
| | |_| | | | (_| | | Version 1.14.0-DEV.1292 (2025-11-24)
_/ |\__'_|_|_|\__'_| | jitlink-cgmemmgr/068186c191 (fork: 2 commits, 0 days)
|__/ |
julia> |
Member
Is this in spec? |
Member
Author
|
It's allowed but not required:
|
Keno
approved these changes
Nov 25, 2025
Member
Member
Author
|
The CI error is the code model problem from before (DualMapAllocator puts an RX mapping more than 2 GiB from an RW or RO mapping that a relocation points to), but I made the error message worse with Partial revert in #60245. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple ARM CPUs treat the
ic ivauas a memory read, which causes a confusing crash in DualMapAllocator if we try using it on awr_addrthat has been mprotected toProt::NO, since we are still holding the allocator lock.For Apple aarch64 systems with SIP disabled, this will result in some memory savings, since DualMapAllocator will now work there. Like before, other JITLink platforms, namely Linux aarch64 and RISC-V, will benefit too.
This re-lands #60105, after it was reverted in #60196. Thanks @giordano!