Skip to content

Fix throwing when stdlibs don't build. REPL precomp script fixes #60240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix throwing when stdlibs don't build. REPL precomp script fixes #60240

wants to merge 3 commits into from
+66 −68

Conversation

@IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Nov 25, 2025 •
edited
Loading

Fixes #60239

  • Make building the stdlibs throw if they error(!).. I believe they used to but regressed somewhere..
  • Add a prompt event to REPL and use it to orchestrate the precompile script, rather than awkwardly reading for prompt prints

@IanButterworth IanButterworth added the DO NOT MERGE Do not merge this PR! label Nov 25, 2025
@IanButterworth IanButterworth force-pushed the ib/loading_debug branch 2 times, most recently from ea2521d to c056aa0 Compare November 29, 2025 12:52
@IanButterworth

This comment was marked as resolved.

Sign in to view
@IanButterworth

This comment was marked as resolved.

Sign in to view
@IanButterworth IanButterworth removed the DO NOT MERGE Do not merge this PR! label Nov 30, 2025
@IanButterworth IanButterworth changed the title debug: always show precompile message Fix throwing when stdlibs don't build. REPL precomp script fixes Nov 30, 2025
@IanButterworth IanButterworth marked this pull request as ready for review November 30, 2025 00:20
@IanButterworth IanButterworth added building Build system, or building Julia or its dependencies REPL Julia's REPL (Read Eval Print Loop) labels Nov 30, 2025
@IanButterworth IanButterworth force-pushed the ib/loading_debug branch 2 times, most recently from 237202e to df26e37 Compare November 30, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

building Build system, or building Julia or its dependencies REPL Julia's REPL (Read Eval Print Loop)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

REPL being precompiled during REPL tests, and fails to precompile

1 participant

@IanButterworth