Proactively compile lambdas when the type of the closure is known #60259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a method we precompile instantiates a closure struct, and there is a single
compileable signature for the closure method, we can compile the closure method
with few downsides.
For example:
```
f(x::T) where {T <: Number} = y::T -> x+y
precompile(f, (Int,))
f(1)(2)
```
Before, the closure method would not get precompiled, resulting in
`--trace-compile` output:
`precompile(Tuple{Foo.var"#f##0#f#JuliaLang#1"{Int64, Int64}, Int64})`
This idea was motivated by trying to make the REPL precompile script more
"static". Creating a task with `@task` or `@async` expands into a no-argument
lambda, which won't get precompiled with the containing method.
Member
|
Seems fine, but wouldn't this be better handled by understanding the edge intrinsic that we added (I think) for juliac purposes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a method we precompile instantiates a closure struct, and there is a single compileable signature for the closure method, we can compile the closure method with few downsides.
For example:
Before, the closure method would not get precompiled, resulting in
--trace-compileoutput:precompile(Tuple{Foo.var"#f##0#f##1"{Int64, Int64}, Int64})This idea was motivated by trying to make the REPL precompile script more "static". Creating a task with
@taskor@asyncexpands into a no-argument lambda, which won't get precompiled with the containing method.