Check type hash as an early out in egal_types
#60264
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were mostly curious whether the
hashfield ofjl_datatype_tcould be utilized to speed up type comparisons, as those showed up in our CPU profiles during package image loading (i.e. injl_types_equalandjl_types_egal). After discussing this idea briefly in the public Julia slack (thread), @nathan and @topolarity suggested bringing this idea forward to discuss whether it's legal and worthwhile with a broader audience.CC: @vtjnash, who perhaps knows best whether the idea makes sense.