refactor: move commands into a module hierarchy #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaadiSave
commented
Nov 19, 2025
| env_logger::init_from_env(env); | ||
|
|
||
| #[cfg(feature = "winpkgidentityext")] | ||
| #[cfg(all(windows, feature = "winpkgidentityext"))] |
Author
There was a problem hiding this comment.
I was testing the feature powerset with cargo-hack. Since the windows crate is only available on windows, it threw a compile error.
SaadiSave
commented
Nov 19, 2025
| shell: CompletionShell, | ||
| app_name: &str, | ||
| ) -> Result<()> { | ||
| pub fn generate<T: CommandFactory>(shell: CompletionShell, app_name: &str) -> Result<()> { |
Author
There was a problem hiding this comment.
command::completions::generate is self-explanatory in code
SaadiSave
commented
Nov 19, 2025
| "default" => None, | ||
| _ => { | ||
| return Err(anyhow!( | ||
| _ => bail!( |
Author
There was a problem hiding this comment.
Changed to bail! for consistency with other parts of the codebase
SaadiSave
commented
Nov 19, 2025
| @@ -0,0 +1,15 @@ | |||
| pub mod autoinstall; | |||
|
|
|||
| #[cfg(feature = "selfupdate")] | |||
Author
There was a problem hiding this comment.
Moved feature gates to module-level where possible
SaadiSave
commented
Nov 19, 2025
| config_file::{load_mut_config_db, save_config_db, JuliaupConfigChannel}, | ||
| global_paths::GlobalPaths, | ||
| operations::garbage_collect_versions, | ||
| utils::{print_juliaup_style, JuliaupMessageType}, |
Author
There was a problem hiding this comment.
Intra-file import consistency (either nested or unnested)
SaadiSave
force-pushed
the
main
branch
3 times, most recently
from
1f4b862 to
cde89d1
Compare
SaadiSave
commented
Nov 19, 2025
| global_paths::GlobalPaths, | ||
| jsonstructs_versionsdb::JuliaupVersionDB, | ||
| versions_file::load_versions_db, | ||
| }; |
simplify call-site fixes JuliaLang#313 (partially?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #313 (partially?)
@davidanthoff, @uncomfyhalomacro
finally found enough time to implement my issue
I believe things have calmed down in this part of the codebase. The last significant commit was months ago.
I have commented every change unrelated to the module tree.