Skip to content

Conversation

Davide-Miotti
Copy link
Member

No description provided.

Copy link

claude bot commented Sep 5, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 26.79426% with 153 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/solve_utils.jl 37.41% 87 Missing ⚠️
src/solve_hermite.jl 0.00% 36 Missing ⚠️
src/boundary_types.jl 0.00% 30 Missing ⚠️
Files with missing lines Coverage Δ
src/RadialBasisFunctions.jl 100.00% <ø> (ø)
src/interpolation.jl 100.00% <100.00%> (ø)
src/solve.jl 100.00% <100.00%> (ø)
src/boundary_types.jl 0.00% <0.00%> (ø)
src/solve_hermite.jl 0.00% <0.00%> (ø)
src/solve_utils.jl 39.16% <37.41%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member Author

@Davide-Miotti Davide-Miotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look very good to me, there will always be room for further optimization but this is already a good point.. I tried to removed from solve_hermite.jl the duplicated code from solve.jl and it still seems to work, I'll commit that one

Copy link

claude bot commented Sep 14, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@test length(hermite_data.normals) == 3

println(" ✓ Basic functionality works correctly")

println("✓ All clean Hermite implementation tests passed!")
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
end
end

Copy link

claude bot commented Sep 14, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants