-
Notifications
You must be signed in to change notification settings - Fork 1
Hermite kyle davide #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: hermite-kyle
Are you sure you want to change the base?
Conversation
Claude encountered an error —— View job I'll analyze this and get back to you. |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look very good to me, there will always be room for further optimization but this is already a good point.. I tried to removed from solve_hermite.jl the duplicated code from solve.jl and it still seems to work, I'll commit that one
Claude encountered an error —— View job I'll analyze this and get back to you. |
@test length(hermite_data.normals) == 3 | ||
|
||
println(" ✓ Basic functionality works correctly") | ||
|
||
println("✓ All clean Hermite implementation tests passed!") | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
end | |
end | |
Claude encountered an error —— View job I'll analyze this and get back to you. |
No description provided.