More optimize_ticks improvements #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeastyBlacksmith
force-pushed
the
ticks-struct
branch
from
db01b5e to
5effa77
Compare
Member
|
I rebased and formatted this PR just to better see the difference to the current version. It would still be neccessary to check whether the algorithms are doing what they shoud do. |
Member
|
Is this really rebased ? It looks like it reverts recent additions (especially #136 which is critical). |
Member
Well, when in doubt, I kept the original version, so there is certainly stuff that'd need to be adapted. |
Member
|
I think this is as far as I can help here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #83 (comment), I realized that actual floating point are not really used during the optimization, so most FP calculations can be avoided. Representing the ticks as a new
Tickstype and calculating FP values only ongetindexmakes things both simpler and faster.Also, unitful quantities work now.
This makes two tests fail. Specifically,
optimize_ticks(1.0,1.0+eps())andoptimize_ticks(1.0-eps(),1.0), so I marked them as broken. These do issue a warning and the result is sensible, so I think it's fine.