Skip to content

Write empty Deps.toml and Compat.toml files, but don't write empty WeakDeps.toml or WeakCompat.toml files #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2023
Merged

Write empty Deps.toml and Compat.toml files, but don't write empty WeakDeps.toml or WeakCompat.toml files #82

merged 1 commit into from
Jan 16, 2023

Conversation

@DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jan 16, 2023

Fixes #81

@DilumAluthge
Write empty Deps.toml and Compat.toml files, but don't write empt…
31f5f74 
…y `WeakDeps.toml` or `WeakCompat.toml` files
@DilumAluthge DilumAluthge requested a review from nkottary January 16, 2023 06:10
@nkottary nkottary merged commit 05fd1ff into master Jan 16, 2023
@nkottary nkottary deleted the dpa/empty-toml-files branch January 16, 2023 06:55
@nkottary nkottary mentioned this pull request Jan 16, 2023
Closed
@KristofferC
Copy link
Member

KristofferC commented Jan 28, 2023

I still don't see why we should be writing empty files. What's the point?

DilumAluthge added a commit that referenced this pull request Feb 17, 2023
@DilumAluthge
Revert "Write empty Deps.toml and Compat.toml files, but don't wr…
e57a354 
…ite empty `WeakDeps.toml` or `WeakCompat.toml` files (#82)"

This reverts commit 05fd1ff.
@DilumAluthge DilumAluthge mentioned this pull request Feb 17, 2023
Open
1 task
@DilumAluthge
Copy link
Member Author

DilumAluthge commented Feb 25, 2023

I still don't see why we should be writing empty files. What's the point?

Let's revert this PR.

#84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkottary nkottary nkottary approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: RegistryTools no longer creates empty Deps.toml or Compat.toml files

4 participants

@DilumAluthge @KristofferC @nkottary