Skip to content

Conversation

farhadrclass
Copy link
Contributor

@farhadrclass farhadrclass commented Feb 5, 2025

Overview

This PR introduces the new R2N solver, a first-order quadratic regularization method for unconstrained optimization, along with the implementation of a shifted system solver function. These contributions provide robust and efficient tools for solving challenging optimization tasks.

Key Additions

  1. Introduction of R2N Solver:
    • Implements a first-order quadratic regularization approach.

Usage Example

solver = R2NSolver(nlp)
solve!(solver, nlp; kwargs...)

Parameters

  • nlp::AbstractNLPModel{T, V}: The model to solve, as defined in NLPModels.jl.
  • Keyword Arguments:
    • x::V = nlp.meta.x0: Initial guess.
    • atol::T = √ε(T): Absolute tolerance.
    • rtol::T = √ε(T): Relative tolerance, where the algorithm stops when ‖∇f(xᵏ)‖ ≤ atol + rtol * ‖∇f(x⁰)‖.
    • η1 = ε(T)^(1/4), η2 = T(0.95): Step acceptance parameters.
    • γ1 = T(1/2), γ2 = 1/γ1: Regularization update parameters.
    • σmin = ε(T): Step parameter.
    • max_eval::Int = -1: Maximum number of objective function evaluations.
    • max_time::Float64 = 30.0: Maximum time limit in seconds.
    • max_iter::Int = typemax(Int): Maximum number of iterations.
    • β = T(0) ∈ [0,1]: Momentum term constant. No momentum if β == 0.
    • verbose::Int = 0: Display iteration details every verbose iteration.
    • subsolver_type::Union{Type{<:KrylovSolver}, Type{ShiftedLBFGSSolver}} = ShiftedLBFGSSolver: Subsolver for the shifted system, defaulting to ShiftedLBFGSSolver.
    • subsolver_verbose::Int = 0: Displays iteration information for the subsolver when subsolver_verbose > 0.

We need to check the obj once it has been accepted
fix the restart issue

Update R2N.jl

Update callback.jl

Allocate test
@farhadrclass farhadrclass changed the title Introduction of R2N Solver and Shifted System Solver in JSOSolvers Introduction of R2N Solver in JSOSolvers Feb 5, 2025
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @farhadrclass for the PR. A first batch of comments.
The tests fail because of extra allocations. Any idea why?

What are the differences with FOMO?

fixed the bug

Test  edge cases, and make the reviews

Update R2N.jl

R2N Edge cases

Update test_edge_cases.jl
@tmigot tmigot marked this pull request as draft July 7, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants