Fix error on 0.0 with format "g/G" #93
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R3G3N3R4T0R
force-pushed
the
mine/0.0-fix
branch
from
9c33b01 to
58e01b7
Compare
g/G currently lacks a testset. This testset is currently non-compilant to Python's format_spec as trailing zeros are retained. Added FIXME to remind future maintainers.
R3G3N3R4T0R
force-pushed
the
mine/0.0-fix
branch
from
58e01b7 to
dd673ab
Compare
R3G3N3R4T0R
force-pushed
the
mine/0.0-fix
branch
from
dd673ab to
9ad7ab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After my erroneous patch (04baaf3), the
floor(Int, log10(x))would trigger InexactError ifx == 0.0. This PR address that and add an extensive testset to prevent regression. The testset is GPT-5 generated but I have reviewed and edited it manually.The testset validate current behavior instead of Python's. If in the future "g/G" is set to remove trailing zeros, it has to be edited. A FIXME has been added to remind future maintainers.