Skip to content

Conversation

@IanButterworth
Copy link
Collaborator

@IanButterworth IanButterworth commented Apr 15, 2025

I think this is ok as a direct dep?
Also, needs testing.

If REFERENCETESTS_SIXEL=1

Screenshot 2025-04-15 at 1 04 20 PM

@oxinabox
Copy link
Member

Sixel actually adds a 50 direct dependencies, including ImageCore, which we currently use a hack to avoid depending on directly.
With that said maybe we should just depend on it (and ImageCore and XImageInTerm) directly,
making maintenance and use easier.

If we are depending on it directly, i think we don't need to use a enviroment variable to decide if to use it or not, and can just use Sixel.is_sixel_supported() and if so always use it. Its always better, no?

@IanButterworth
Copy link
Collaborator Author

Unfortunately that returns false inside the Pkg.test worker in a local terminal where it otherwise returns true.

@oxinabox
Copy link
Member

Oh thats annoying we should open an issue on Sixel.jl about that

@IanButterworth
Copy link
Collaborator Author

Attempts to fix it here JuliaIO/Sixel.jl#29

Pkg discussion about it here JuliaLang/Pkg.jl#3185 (comment)

@MasonProtter
Copy link

I really want this and I'm fine with setting an env variable to get it FWIW.

@oxinabox
Copy link
Member

I propose the following things:

  • Fix CI
  • Add this to docs/readme
  • Open issue to do automatically once we workout how (cross link to the julia issue)
  • Remove @lazy loads from modules that are already loaded by Sixel.jl and if that is all of them remove dependency on LazyModules.jl

@IanButterworth
Copy link
Collaborator Author

Please feel free to take this over. It's not a high priority for me right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants