digestsign interface for EVP_DigestSign cryptographic signatures #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is in preparation for adding signature support in the digests section
but doesn't seem to be working properly yet ...
- exports now listed in file order and grouped by relevance
- removed undefined exports (TLSv12ClientMethod, TLSv12ServerMethod, read)
- removed EvpMD2 and EvpDSS1 which don't correspond to openssl symbols
- closes JuliaWeb#28
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
- Coverage 77.56% 74.34% -3.22%
==========================================
Files 2 2
Lines 1083 1068 -15
==========================================
- Hits 840 794 -46
- Misses 243 274 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
I don't know what's going on with the nightly tests but I don't think they're my fault. As for lts, do we want to support OpenSSL v1 still? EVP_DigestSignUpdate() was converted from a macro to a function in OpenSSL 3.0. I can try to support pre-v3 by switching on the openssl version and just calling DigestUpdate instead, but personally I find this a bit cursed. OpenSSL v3 is stable in virtually every environment known to man. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial support for the OpenSSL EVP_DigestSign interface, as per #49. At least RSA signing should work now. Also tidy up some stuff (closes #28 on the side).