cxx-qt-build: improve support for qmlls qmllint #1343
Draft
+659
−223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 13051 13081 +30
=========================================
+ Hits 13051 13081 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ahayzen-kdab
force-pushed
the
975-improve-support-for-qmlls-qmllint
branch
from
f4bdc20 to
278113c
Compare
This allows them to understand the std numerics when namespaced as Qt only registers int32_t not ::std::int32_t so qmllint and qmlls state the type is not resolved.
Otherwise moc does not understand their expansion. Beforw we were manually using the expansion via Q_CLASSINFO but the macros have other code so this resolves the original problem.
This allows for moc to read the .cxx.h for other includes
It becomes confused about the QQuickPaintedItem parent that is not exposed through to .qmltypes
ahayzen-kdab
force-pushed
the
975-improve-support-for-qmlls-qmllint
branch
from
481be2d to
d131194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #975