WIP: Investigate linker error in QML module simplification #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LeonMatthesKDAB
commented
Oct 9, 2025
LeonMatthesKDAB
commented
- Remove QRC files from QML modules
- CXX-Qt-Build: Move QmlModule to builder pattern
- CXX-Qt-Build: Pass QmlModule into new
This is for the most part already covered by the .qrc function in CxxQtBuilder.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1348 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 13051 13051
=========================================
Hits 13051 13051 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LeonMatthesKDAB
force-pushed
the
simplify-qml-modules-investigate-linker
branch
from
9356441 to
265d2df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.