Imported error classes from sdk #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Dudleyneedham
left a comment
Dudleyneedham
left a comment
There was a problem hiding this comment.
Looks fine, but you need to update your linting settings in visual studio code.
| archiver-utils "^3.0.4" | ||
| compress-commons "^4.1.2" | ||
| readable-stream "^3.6.0" | ||
| readable-stream "^3.6.0" |
Member
There was a problem hiding this comment.
Why is this missing?
Maybe in your settings you don't include line break at the bottom.
| } | ||
| import { SDKErrors } from '@kiltprotocol/sdk-js' | ||
|
|
||
| export declare class SignatureMalformedError extends MessageError {} |
Member
|
I also noticed that the linting isnt working can we try to fix this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#3077
The error classes from the extension now extend the error class from the sdk. They should be now an instance of the sdk error class. Also the error classes from the sdk are imported and are not implemented in the extension again.
I first imported the class directly from '@kiltprotocol/utils', where the SDKError.ts file is located, but this resulted in the issue of having different instances of the classes.
Checklist: