kotlin sample app #322
Open
kotlin sample app #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiphirx
requested changes
Dec 7, 2018
| // This listener will tell us when interesting(tm) events happen in regards | ||
| // to the sequence | ||
| override fun onSequenceFinish() { | ||
| (findViewById<View>(R.id.educated) as TextView).text = "Congratulations! You're educated now!" |
There was a problem hiding this comment.
Suggested change
| (findViewById<View>(R.id.educated) as TextView).text = "Congratulations! You're educated now!" | |
| findViewById<TextView>(R.id.educated).text = "Congratulations! You're educated now!" |
| } | ||
|
|
||
| override fun onSequenceStep(lastTarget: TapTarget, targetClicked: Boolean) { | ||
| Log.d("TapTargetView", "Clicked on " + lastTarget.id()) |
There was a problem hiding this comment.
Suggested change
| Log.d("TapTargetView", "Clicked on " + lastTarget.id()) | |
| Log.d("TapTargetView", "Clicked on ${lastTarget.id()}") |
| .setMessage("You canceled the sequence") | ||
| .setPositiveButton("Oops", null).show() | ||
| TapTargetView.showFor(dialog, | ||
| TapTarget.forView(dialog.getButton(DialogInterface.BUTTON_POSITIVE), "Uh oh!", "You canceled the sequence at step " + lastTarget.id()) |
There was a problem hiding this comment.
Suggested change
| TapTarget.forView(dialog.getButton(DialogInterface.BUTTON_POSITIVE), "Uh oh!", "You canceled the sequence at step " + lastTarget.id()) | |
| TapTarget.forView(dialog.getButton(DialogInterface.BUTTON_POSITIVE), "Uh oh!", "You canceled the sequence at step ${lastTarget.id()}") |
| override fun onTargetDismissed(view: TapTargetView, userInitiated: Boolean) { | ||
| Log.d("TapTargetViewSample", "You dismissed me :(") | ||
| } | ||
| }) |
There was a problem hiding this comment.
Formatting:
TapTargetView.showFor(
this,
TapTarget.forView(findViewById<View>(R.id.fab), "Hello, world!", spannedDesc)
.cancelable(false)
.drawShadow(true)
.titleTextDimen(R.dimen.title_text_size)
.tintTarget(false),
object : TapTargetView.Listener() {
override fun onTargetClick(view: TapTargetView) {
super.onTargetClick(view)
// .. which evidently starts the sequence we defined earlier
sequence.start()
}
override fun onOuterCircleClick(view: TapTargetView) {
super.onOuterCircleClick(view)
Toast.makeText(view.context, "You clicked the outer circle!", Toast.LENGTH_SHORT).show()
}
override fun onTargetDismissed(view: TapTargetView, userInitiated: Boolean) {
Log.d("TapTargetViewSample", "You dismissed me :(")
}
}
)| TapTargetView.showFor(dialog, | ||
| TapTarget.forView(dialog.getButton(DialogInterface.BUTTON_POSITIVE), "Uh oh!", "You canceled the sequence at step " + lastTarget.id()) | ||
| .cancelable(false) | ||
| .tintTarget(false), object : TapTargetView.Listener() { |
There was a problem hiding this comment.
Formatting, move object onto its own line
| @@ -1,4 +1,5 @@ | |||
| buildscript { | |||
| ext.kotlin_version = '1.2.71' | |||
There was a problem hiding this comment.
Move this version definition to the ext block below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a Quick Kotlin sample application.