-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(agent-manager): add YOLO mode toggle and session rename #4890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add YOLO mode toggle button in session header to enable/disable auto-approval of operations with indicator in session list. Add inline session rename functionality. Also fixes messages not loading when reopening panel and race condition with pending session timeout.
🦋 Changeset detectedLatest commit: f1184c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@marius-kilocode Thanks for testing! The Could you check if you have a local CLI configuration that auto-approves |
|
I dug a bit further. If i switch in an independent CLI to yolo mode the approval buttons don't work anymore. Once I switch back in a separate CLI to non-yolo the buttons work. I suspect this might either be a bug attached to: //The code in question (cli.ts:287-295):
// In JSON-IO mode, don't set yoloMode on the extension host.
// This prevents Task.ts from auto-answering followup questions.
// The CLI's approval layer handles YOLO behavior and correctly excludes followups.
if (!this.options.jsonInteractive) {
extensionHost.sendWebviewMessage({
type: "yoloMode",
bool: Boolean(this.options.ci || this.options.yolo),
})
}which we might just remove now as we disabled the question tool in yolo mode on main. Or it is some |
|
I investigated the // cli/src/config/defaults.ts
execute: {
enabled: true,
allowed: ["ls", "cat", "echo", "pwd"],
denied: ["rm -rf", "sudo rm", "mkfs", "dd if="],
}
Still investigating the global state issue you mentioned separately. |
|
@marius-kilocode Regarding your observation:
I'd like to understand better what's happening. Here's what I think the issue might be: My understanding: Proposed solution:
Questions:
I want to make sure I'm solving the right problem before pushing the fix. |

Summary
Bug Fixes
Improvements
respondToApprovalandrenameSessionmessagesScreenshots
YOLO Mode Toggle
Session with YOLO Mode (Auto-approve)
No Approve/Deny buttons - operations are auto-approved:
Session without YOLO Mode (Manual approval)
Approve/Deny buttons visible for each operation:
Approval Button States
Inline Session Rename
Test plan