-
Notifications
You must be signed in to change notification settings - Fork 118
Support new maven central publication scheme #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@ilya-g proposed to move these new jobs directly to kotlinx infra plugin and then simply regenerate configs in related projects. That's definitely the way to go, but I want to merge this PR into the datetime first, to avoid further |
@fzhinkin, we don't need to actually merge it to publish 0.7.1, we can just set this branch as the default one (and also check how well it works along the way before merging). The current branch from where TeamCity obtains its settings is #553; could you please rebase on top of it so that we have a branch where all's well? |
.teamcity/CentralDeployment.kt
Outdated
"publishAndroidNativeX64PublicationToCentralRepository", | ||
"publishAndroidNativeX86PublicationToCentralRepository", | ||
"publishLinuxArm64PublicationToCentralRepository", | ||
"publishLinuxX64PublicationToCentralRepository" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do all these tasks come from? /gradlew tasks | grep publish | grep Central
returns nothing for me. The old Deploy
builds only have clean publish
, and I do have publish
in my list of tasks.
Also, if this conditional publication depending on the platform is an optimization here, then can't kotlinx-datetime
be optimized to just clean publish
on just MacOS
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do all these tasks come from?
You have to add following Gradle properties to get those tasks:
-Pteamcity=on -Plibs.repo.url=https://localhost -Plibs.repo.user=user -Plibs.repo.password=password
Also, if this conditional publication depending on the platform is an optimization here, then can't
kotlinx-datetime
be optimized to justclean publish
on justMacOS
?
Sure, let's do that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
6d88a66
to
637db6c
Compare
But now it's |
dependsOnSnapshot(startDeployment) | ||
|
||
triggers { | ||
finishBuildTrigger { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why finishBuildTrigger
is used here, i.e. why the first build in chain triggers subsequent ones instead of an aggregate build configuration running dependencies, like it was before?
Will it be possible not to publish TZ info for -compat
versions, for example, with this setup?
It is not longer possible to publish artifacts to sonatype staging repositories and the central publishing portal has to be used instead.
The PR adds TC jobs publishing all the artifacts into intermediate maven repo and then collect all the artifacts into a single deployment uploaded to the portal.