changed default from ball_tree to auto. Should be faster now for larger datasets #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed default knn search algo from "ball_tree" to "auto".
When we pass "auto", if number of input dimensions in >20, then sklearn selects brute force.
We pass 50 or 100D PCA into PHATE.
It turns out that for "ball_tree" and "kd tree" become slow when the number of features is >20:
https://scikit-learn.org/stable/modules/neighbors.html#nearest-neighbor-algorithms
Here are results running PHATE on AMD EPYC 7543 32-Core Processor with 256GB RAM requested.
PHATE fitted on 100K
sklearn.datasets.make_blobs.Before:
With change: